Skip to content

Some small refactors#33144

Merged
lunny merged 8 commits intogo-gitea:mainfrom
lunny:lunny/refactor
Jan 10, 2025
Merged

Some small refactors#33144
lunny merged 8 commits intogo-gitea:mainfrom
lunny:lunny/refactor

Conversation

@lunny
Copy link
Copy Markdown
Member

@lunny lunny commented Jan 8, 2025

No description provided.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jan 8, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 8, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 8, 2025
wxiaoguang
wxiaoguang reviewed Jan 8, 2025
View reviewed changes
Comment thread models/issues/comment_list.go Outdated
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 9, 2025
wxiaoguang
wxiaoguang reviewed Jan 9, 2025
View reviewed changes
Comment thread models/issues/comment_list.go Outdated
wxiaoguang
wxiaoguang reviewed Jan 9, 2025
View reviewed changes
Comment thread models/user/user_list.go Outdated
wxiaoguang
wxiaoguang reviewed Jan 9, 2025
View reviewed changes
Comment thread models/user/user_list.go Outdated
wxiaoguang
wxiaoguang reviewed Jan 9, 2025
View reviewed changes
Comment thread routers/web/repo/issue_view.go
wxiaoguang
wxiaoguang reviewed Jan 9, 2025
View reviewed changes
Comment thread models/user/user_list.go Outdated
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 10, 2025
@lunny lunny enabled auto-merge (squash) January 10, 2025 05:47
@lunny lunny merged commit d3083d2 into go-gitea:main Jan 10, 2025
@GiteaBot GiteaBot added this to the 1.24.0 milestone Jan 10, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 10, 2025
@lunny lunny deleted the lunny/refactor branch January 12, 2025 01:32
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 14, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
589d5fc 
* giteaofficial/main: (21 commits)
  Support public code/issue access for private repositories (go-gitea#33127)
  Validate that the tag doesn't exist when creating a tag via the web (go-gitea#33241)
  [skip ci] Updated translations via Crowdin
  Switch back to `vue-tsc` (go-gitea#33248)
  Let API create and edit system webhooks, attempt 2 (go-gitea#33180)
  Fix incorrect ref "blob" (go-gitea#33240)
  Refactor RefName (go-gitea#33234)
  Refactor context RefName and RepoAssignment (go-gitea#33226)
  [skip ci] Updated translations via Crowdin
  Fix upload file form (go-gitea#33230)
  Fix mirror bug (go-gitea#33224)
  Remove unused CSS styles and move some styles to proper files (go-gitea#33217)
  Refactor context repository (go-gitea#33202)
  [skip ci] Updated translations via Crowdin
  Fix unpin hint on the pinned pull requests (go-gitea#33207)
  fix(cache): cache test triggered by non memory cache (go-gitea#33220)
  Update README.md (go-gitea#33149)
  Fix editor markdown not incrementing in a numbered list (go-gitea#33187)
  Some small refactors (go-gitea#33144)
  Fix sync fork for consistency (go-gitea#33147)
  ...
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Apr 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wxiaoguang wxiaoguang wxiaoguang left review comments

@lafriks lafriks lafriks approved these changes

@delvh delvh delvh approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

1.24.0

Development

Successfully merging this pull request may close these issues.

5 participants

@lunny @lafriks @wxiaoguang @delvh @GiteaBot